Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSAD Camera movement #53

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

Bazsi1224
Copy link
Contributor

@Bazsi1224 Bazsi1224 commented Jun 23, 2023

Solves issue #18

Camera movement was moved from _unhandled_input to _process, otherwise the two input was interfering each other, now the mouse input will overwrite the keyboard.

Also _move does not get the mouse position as parameter rather gets directly from viewport

@Scony Scony added enhancement New feature or improvement to be implemented refactoring Change in the code without functional impact labels Jun 24, 2023
@Scony Scony added this to the 1.0 milestone Jun 24, 2023
@Scony Scony force-pushed the main branch 5 times, most recently from 7a27d8b to e8fcedf Compare June 24, 2023 12:31
@Scony Scony force-pushed the 18-Add-WASD-camera-movement branch from ab7a901 to 6b25d8f Compare June 25, 2023 08:26
Camera movement was moved from _unhandled_input to _process, otherwise the two input was interfering each other, now the mouse input will overwrite the keyboard.

Also _move does not get the mouse position as parameter rather gets directly from viewport
@Scony Scony force-pushed the 18-Add-WASD-camera-movement branch from 6b25d8f to 2b9b699 Compare June 25, 2023 08:33
@Scony
Copy link
Contributor

Scony commented Jun 25, 2023

I've reformatted and squashed the changes.
Thanks for contributing!

@Scony Scony merged commit 593f08e into lampe-games:main Jun 25, 2023
@Bazsi1224 Bazsi1224 deleted the 18-Add-WASD-camera-movement branch June 26, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to be implemented refactoring Change in the code without functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants