#52 Rally Points are added #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camera movement was moved from _unhandled_input to _process, otherwise the two input was interfering each other, now the mouse input will overwrite the keyboard. Also _move does not get the mouse position as parameter rather gets directly from viewport
WSAD Camera movement
From now each unit factory shall have a RallyPoint node. if its position is (0,0,0) the rally has no effect, otherwise the units will be sended to its position
…or-unit-factories lampe-games#51 add rally flags for unit factories
…or-unit-factories minor format changes
|
Thanks, I'll need a day or two to review. If possible please squash commits into one as the change is not very large. |
|
sure thing, I am pretty new to GitHub, so sorry if I do something wrong. |
|
I've checked the changes and they look pretty good. I'll integrate them manually. I'll also add a few improvements. |
|
Changes merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each unit production building has a node RallyPoint. Each freshly generated unit will automatically go there.
Planned to making able to select resource as rallyPoint to start gathering automatically.
Visuals shall be updated, as the current one is a glowing cylinder