Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Positioned#cloneIn #13627

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Fix Positioned#cloneIn #13627

merged 1 commit into from
Sep 30, 2021

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Sep 28, 2021

Fixes #13626.

@mbovel mbovel self-assigned this Sep 28, 2021
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you squash the two commits together? Having the functional changes and the tests in the same commit makes it easier to tell what a change is for when stumbling upon it via git blame for example.

@smarter
Copy link
Member

smarter commented Sep 30, 2021

One more nitpick: descriptive commit messages are nicer, so consider using a commit title like "Fix Positioned#cloneIn to also update the source" instead of "Fix #13626" (and move the "fix #..." in the commit message body), I think you said this fixes a regression, so you could also mention the commit where the regression was introduced in your commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong position of quote content
3 participants