Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Move writer API a private API #329

Merged
merged 2 commits into from
Nov 23, 2022
Merged

[C++] Move writer API a private API #329

merged 2 commits into from
Nov 23, 2022

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Nov 23, 2022

Closes #302

@eddyxu eddyxu added the c++ C++ issues label Nov 23, 2022
@eddyxu eddyxu requested a review from changhiskhan November 23, 2022 07:50
@eddyxu eddyxu self-assigned this Nov 23, 2022
@eddyxu
Copy link
Contributor Author

eddyxu commented Nov 23, 2022

Pending #327 to fix arrow build

@changhiskhan
Copy link
Contributor

so after this users should be doing pyarrow.dataset.write_dataset(..., mode='append') instead of lance.write_dataset? The read path is still lance.dataset right?

changhiskhan
changhiskhan approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending CI

@changhiskhan changhiskhan merged commit 67c9546 into main Nov 23, 2022
@changhiskhan changhiskhan deleted the lei/private_writer_api branch November 23, 2022 14:14
@eddyxu
Copy link
Contributor Author

eddyxu commented Nov 23, 2022

so after this users should be doing pyarrow.dataset.write_dataset(..., mode='append') instead of lance.write_dataset?

It still uses lance.write_dataset for versioned dataset. This is just C++ side change, which is not standard arrow C++ api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

Assignees

@eddyxu eddyxu

Labels
c++ C++ issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++] Move lance/arrow/write.h to private interface.
2 participants
@eddyxu @changhiskhan