Integrate flat index #448
Merged
Integrate flat index #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust/src/index/vector/flat.rs
Outdated
| @@ -17,7 +17,10 @@ | |||
|
|
|||
| //! Flat Vector Index. | |||
|
|
|||
| use std::sync::Arc; | |||
rust/src/io/reader.rs
Outdated
| @@ -202,6 +202,7 @@ impl<'a> FileReader<'a> { | |||
| let indices_in_batches = self.metadata.group_indices_to_batches(indices); | |||
| let batches = stream::iter(indices_in_batches) | |||
| .then(|batch| async move { | |||
| println!("Read batch: {:?}", batch); | |||
rust/src/io/exec/knn.rs
Outdated
| .zip(stream::repeat_with(|| q.clone())) | ||
| .then(|(batch, q)| async move { | ||
| let batch = batch?; | ||
| let vectors = batch.column_with_name(&q.column).unwrap().clone(); |
There was a problem hiding this comment.
A lot of mixing of ? And unwraps. Feels like should be using ? As much as possible here
eddyxu
force-pushed
the
lei/integrate_flat_idx
branch
from
8d7b795 to
c43390e
Compare
changhiskhan
approved these changes
Jan 23, 2023
| columns.push(self.column(i).clone()); | ||
| } | ||
| } | ||
| Ok(RecordBatch::try_new( |
There was a problem hiding this comment.
should we create drop_field in Schema?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.