Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since recipes define their own plugin version dependencies, it's possible to run multiple versions of this plugin in a single app. Each version might depend on its own versions of the scripts it provides. Currently, only one version of the scripts can exist at a time, which can cause issues when the script doesn't match the builder that uses it.
This PR modifies the builder so that it creates a unique path for the service's scripts and copies its own version of the scripts there. e.g.
~/.lando/apps/myapp-fe49e234fdbb10b33c9eff64e431e7197089ff08/service-php-appserver/scripts
The unique directory is mounted in the service at
/opt/lando-service/scripts
.The
install-composer.sh
script is now called from this new mount rather than/helpers
.An
app.js
is added with apost-destroy
hook to clean up the new service directory.