Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique scripts dir per service #159

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Unique scripts dir per service #159

merged 3 commits into from
Jan 15, 2025

Conversation

AaronFeledy
Copy link
Member

Since recipes define their own plugin version dependencies, it's possible to run multiple versions of this plugin in a single app. Each version might depend on its own versions of the scripts it provides. Currently, only one version of the scripts can exist at a time, which can cause issues when the script doesn't match the builder that uses it.

This PR modifies the builder so that it creates a unique path for the service's scripts and copies its own version of the scripts there. e.g. ~/.lando/apps/myapp-fe49e234fdbb10b33c9eff64e431e7197089ff08/service-php-appserver/scripts

The unique directory is mounted in the service at /opt/lando-service/scripts.

The install-composer.sh script is now called from this new mount rather than /helpers.

An app.js is added with a post-destroy hook to clean up the new service directory.

Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for lando-php ready!

Name Link
🔨 Latest commit fe99fe4
🔍 Latest deploy log https://app.netlify.com/sites/lando-php/deploys/678699eb85c9e90008d6c38d
😎 Deploy Preview https://deploy-preview-159--lando-php.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 7 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@AaronFeledy AaronFeledy merged commit 3e5a237 into main Jan 15, 2025
39 checks passed
@AaronFeledy AaronFeledy deleted the service-scripts branch January 15, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants