Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend[major]: Migrate to nextjs #34

Merged
merged 14 commits into from
Mar 18, 2024
Merged

frontend[major]: Migrate to nextjs #34

merged 14 commits into from
Mar 18, 2024

Conversation

bracesproul
Copy link
Member

@bracesproul bracesproul commented Mar 18, 2024 •
edited
Loading

Closes #30
Closes #29

Changes

  • Migrate from vite to next.js
  • Add ./frontend/Dockerfile and add frontend service to docker-compose
  • Add lint & formatting checks to CI
  • Add frontend build check to CI
  • Update python CI to not run on frontend changes
  • Add .env.example to frontend (for BASE_API_URL)
  • Update some types
  • Add eslint rules
  • Frontend port is now 3000 (nextjs default)
  • Removed all instances of react-router-dom in favor of next/navigation

@bracesproul bracesproul marked this pull request as draft March 18, 2024 20:57
@bracesproul bracesproul changed the title [WIP]frontend[major]: Migrate to nextjs frontend[major]: Migrate to nextjs Mar 18, 2024
@bracesproul bracesproul marked this pull request as ready for review March 18, 2024 21:52
@bracesproul bracesproul marked this pull request as draft March 18, 2024 22:21
@bracesproul bracesproul marked this pull request as ready for review March 18, 2024 22:31
@bracesproul bracesproul merged commit c1f3e94 into main Mar 18, 2024
3 checks passed
@bracesproul bracesproul deleted the brace/migrate-nextjs branch March 18, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate frontend to next.js from vite Add frontend build to docker compose for dev
1 participant
@bracesproul