Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue: Integration tests fail for faiss vector store #5807

Closed
bnassivet opened this issue Jun 7, 2023 · 0 comments · Fixed by #6281
Closed

Issue: Integration tests fail for faiss vector store #5807

bnassivet opened this issue Jun 7, 2023 · 0 comments · Fixed by #6281

Comments

@bnassivet
Copy link
Contributor

Issue you'd like to raise.

Integration tests for faiss vector store fail when run.
It appears that the tests are not in sync with the module implementation.

command: poetry run pytest tests/integration_tests/vectorstores/test_faiss.py

Results summary:

======================================================= short test summary info =======================================================
FAILED tests/integration_tests/vectorstores/test_faiss.py::test_faiss_local_save_load - FileExistsError: [Errno 17] File exists: '/var/folders/nm/q080zph50yz4mcc7_vcvdcy00000gp/T/tmpt6hov952'
FAILED tests/integration_tests/vectorstores/test_faiss.py::test_faiss_similarity_search_with_relevance_scores - TypeError: init() got an unexpected keyword argument 'normalize_score_fn'
FAILED tests/integration_tests/vectorstores/test_faiss.py::test_faiss_invalid_normalize_fn - TypeError: init() got an unexpected keyword argument 'normalize_score_fn'
FAILED tests/integration_tests/vectorstores/test_faiss.py::test_missing_normalize_score_fn - Failed: DID NOT RAISE <class 'ValueError'>
=============================================== 4 failed, 6 passed, 2 warnings in 0.70s ===============================================

Suggestion:

Correct tests/integration_tests/vectorstores/test_faiss.py to be in sync with langchain.vectorstores.faiss
@bnassivet bnassivet changed the title Issue: Integration tests for faiss vector store Issue: Integration tests fail for faiss vector store Jun 7, 2023
@hp0404 hp0404 mentioned this issue Jun 16, 2023
Merged
hwchase17 pushed a commit that referenced this issue Jun 19, 2023
@hp0404
Fix integration tests for Faiss vector store (#6281)
6aa7b04 
Fixes #5807 (issue)

#### Who can review?

Tag maintainers/contributors who might be interested: @dev2049

<!-- For a quicker response, figure out the right person to tag with @

  @hwchase17 - project lead

  Tracing / Callbacks
  - @agola11

  Async
  - @agola11

  DataLoaders
  - @eyurtsev

  Models
  - @hwchase17
  - @agola11

  Agents / Tools / Toolkits
  - @hwchase17

  VectorStores / Retrievers / Memory
  - @dev2049

 -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix integration tests for Faiss vector store hp0404/langchain
1 participant
@bnassivet