Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to pass in ids for opensearch docs #5952

Closed
taekimsmar opened this issue Jun 9, 2023 · 0 comments
Closed

Ability to pass in ids for opensearch docs #5952

taekimsmar opened this issue Jun 9, 2023 · 0 comments

Comments

@taekimsmar
Copy link
Contributor

Feature request

There is no way to update existing vectors in the opensearch implementation for example if some existing text was changed by passing in custom ids.

https://github.com/hwchase17/langchain/blob/master/langchain/vectorstores/opensearch_vector_search.py#L95

Motivation

Pinecone implementation has this basic functionality:
https://github.com/hwchase17/langchain/blob/master/langchain/vectorstores/pinecone.py#L85

Your contribution

I can try to make a PR to mirror the pincone implementation but it would be pretty naive.
@taekimsmar taekimsmar mentioned this issue Jun 23, 2023
Merged
hwchase17 pushed a commit that referenced this issue Jun 24, 2023
@taekimsmar
add optional ids param to opensearch (#6672)
b970b6b 
- Description: add optional ids to allow updating existing opensearch
documents, follows pattern of other vector stores
  - Issue: #5952 
  - Dependencies: None
  - Tag maintainer: @rlancemartin, @eyurtsev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taekimsmar