Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exec command in langserve Dockerfile template #12225

Closed
wants to merge 2 commits into from
Closed

Fix exec command in langserve Dockerfile template #12225

wants to merge 2 commits into from

Conversation

TimChild
Copy link

@eyurtsev -- This is a super quick and easy fix. This is my first contribution, so please let me know if I have missed doing anything that I should have!

Description:
Add poetry run to the the Dockerfile template file final exec command

CMD exec poetry run uvicorn test_serve.server:app --host 0.0.0.0 --port $PORT

instead of just

CMD exec uvicorn test_serve.server:app --host 0.0.0.0 --port $PORT

Issue:
Without the poetry run added, uvicorn is not found at the exec line when running docker compose up

TimChild and others added 2 commits October 24, 2023 13:07
Run command with poetry run (otherwise uvicorn not found).
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 8:23pm

@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Oct 24, 2023
@eyurtsev eyurtsev assigned eyurtsev and unassigned nfcampos Oct 26, 2023
@eyurtsev
Copy link
Collaborator

hi @TimChild thanks for the PR -- we're revamping the CLI completely: see #12284

Thank you for the contribution! I'll close the PR since this version of the CLI has already been removed :(

@eyurtsev eyurtsev closed this Oct 26, 2023
@TimChild TimChild deleted the langserve-docker-fix branch October 26, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants