APIChain add restrictions to domains (CVE-2023-32786) #12747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eyurtsev
commented
Nov 1, 2023
•
eyurtsev
commented
- Restrict the chain to specific domains by default
- This is a breaking change, but it will fail loudly upon object instantiation -- so there should be no silent errors for users
- Resolves CVE-2023-32786
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
eyurtsev
changed the title
baskaryan
reviewed
Nov 1, 2023
| @@ -40,6 +73,19 @@ class APIChain(Chain): | |||
| api_docs: str | |||
| question_key: str = "question" #: :meta private: | |||
| output_key: str = "output" #: :meta private: | |||
| limit_to_domains: Optional[Sequence[str]] = () | |||
There was a problem hiding this comment.
doe we need a default value? we raise a value if one's not explicitly specified anyways
There was a problem hiding this comment.
updated -- but no functional change either way
baskaryan
approved these changes
Nov 1, 2023
xieqihui
pushed a commit
to xieqihui/langchain
that referenced
this pull request
Nov 21, 2023
…2747) * Restrict the chain to specific domains by default * This is a breaking change, but it will fail loudly upon object instantiation -- so there should be no silent errors for users * Resolves CVE-2023-32786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.