Add Hugging Face chat wrapper #14040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XL
andrewrreed
changed the title
fix formatting
|
@hwchase17 When running the unit tests locally, there are 22 tests that are failing, all of which are inside these two files:
However, when I run pytest on each of those files individually with |
baskaryan
reviewed
Nov 30, 2023
libs/langchain/langchain/chat_models/huggingface_chat_wrapper.py
Outdated
Show resolved
Hide resolved
|
@baskaryan The unit tests were failing due to that global import of an optional dependency. Fixed that so everything is passing locally now. Let me know if there's anything else I need to add here (like integration tests)? Thanks! |
andrewrreed
changed the title
|
@baskaryan Looks like
When you get the chance, could you help advise on what might be wrong? Thanks! |
- **Description:** Added a tool called RedditSearchRun and an accompanying API wrapper, which searches Reddit for posts with support for time filtering, post sorting, query string and subreddit filtering. - **Issue:** langchain-ai#13891 - **Dependencies:** `praw` module is used to search Reddit - **Tag maintainer:** @baskaryan , and any of the other maintainers if needed - **Twitter handle:** None. Hello, This is our first PR and we hope that our changes will be helpful to the community. We have run `make format`, `make lint` and `make test` locally before submitting the PR. To our knowledge, our changes do not introduce any new errors. Our PR integrates the `praw` package which is already used by RedditPostsLoader in LangChain. Nonetheless, we have added integration tests and edited unit tests to test our changes. An example notebook is also provided. These changes were put together by me, @Anika2000, @CharlesXu123, and @Jeremy-Cheng-stack Thank you in advance to the maintainers for their time. --------- Co-authored-by: What-Is-A-Username <49571870+What-Is-A-Username@users.noreply.github.com> Co-authored-by: Anika2000 <anika.sultana@mail.utoronto.ca> Co-authored-by: Jeremy Cheng <81793294+Jeremy-Cheng-stack@users.noreply.github.com> Co-authored-by: Harrison Chase <hw.chase.17@gmail.com>
This reverts commit 38813d7. This is a temporary fix, as I don't see a clear way on how to use multiple keys with `Qdrant.from_texts`. Context: langchain-ai#14378
The namespaces like `langchain.agents.format_scratchpad` clogging the API Reference sidebar. This change removes those 3-level namespaces from sidebar (this issue was discussed with @efriis ) --------- Co-authored-by: Erick Friis <erick@langchain.dev>
Many jupyter notebooks didn't pass linting. List of these files are presented in the [tool.ruff.lint.per-file-ignores] section of the pyproject.toml . Addressed these bugs: - fixed bugs; added missed imports; updated pyproject.toml Only the `document_loaders/tensorflow_datasets.ipyn`, `cookbook/gymnasium_agent_simulation.ipynb` are not completely fixed. I'm not sure about imports. --------- Co-authored-by: Erick Friis <erick@langchain.dev>
Updated provider page by adding LLM and ChatLLM references; removed a content that is duplicate text from the LLM referenced page. Updated the collback page
…n into add-hf-chat-wrapper
andrewrreed
commented
Dec 12, 2023
|
Thanks for your help on this @A-Roucher! @baskaryan This PR is now passing all tests and linting checks. Please let us know if anything else is needed to get this merged! |
|
No problem @andrewrreed, looking forward to start using this integration! |
This reverts commit a8f39af.
baskaryan
pushed a commit
that referenced
this pull request
Dec 21, 2023
Builds on #14040 with community refactor merged and notebook updated. Note that with this refactor, models will be imported from `langchain_community.chat_models.huggingface` rather than the main `langchain` repo. --------- Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: ugm2 <unaigaraymaestre@gmail.com> Signed-off-by: Yuchen Liang <yuchenl3@andrew.cmu.edu> Co-authored-by: Andrew Reed <andrew.reed.r@gmail.com> Co-authored-by: Andrew Reed <areed1242@gmail.com> Co-authored-by: A-Roucher <aymeric.roucher@gmail.com> Co-authored-by: Aymeric Roucher <69208727+A-Roucher@users.noreply.github.com>
|
landed in #14736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There previously has been no easy way to make use of models hosted on Hugging Face (via Inference API or Inference Endpoints) in combination with LangChains ChatModel abstraction.
Description
This PR introduces a new chat_model integration that creates a wrapper around the
BaseChatModelclass that interfaces between LangChain's and the hosted LLM by leveraging Hugging Face's Chat Templates.To do
BaseChatModelto interface with HF LLM integrationsdocs/integrations/chatthat demonstrates its useTag maintainer
@hwchase17
Twitter handle
@andrewrreed