Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Typesense vector store #1674

Merged
merged 13 commits into from
May 24, 2023
Merged

Add Typesense vector store #1674

merged 13 commits into from
May 24, 2023

Conversation

jasonbosco
Copy link
Contributor

Related to #931.

Starting this PR to collaborate.

@jasonbosco jasonbosco mentioned this pull request Mar 15, 2023
Closed
@dev2049
Copy link
Contributor

dev2049 commented May 10, 2023

will try to pick this back up this week!

@jasonbosco
Copy link
Contributor Author

Thank you @dev2049!

@dev2049
Copy link
Contributor

dev2049 commented May 18, 2023

@jasonbosco updated. had a couple outstanding questions and would generally be great to get your eyes on it to make sure the default params make sense. if things generally look ok we can add documentation and tests

@jasonbosco
Copy link
Contributor Author

jasonbosco commented May 19, 2023 •
edited
Loading

@dev2049 Thank you for the updates! I've addressed your comments in the set of commits I just pushed.

I also found and fixed a few issues I ran into when I used this branch with an actual langchain example.

The PR now looks good to me!

@jasonbosco jasonbosco marked this pull request as ready for review May 19, 2023 03:06
@dev2049
Copy link
Contributor

dev2049 commented May 22, 2023

looks pretty good to me! could we add an example notebook (can see other vectorstore notebooks in docs as an example)

@dev2049 dev2049 added the needs documentation PR needs to be updated with documentation label May 23, 2023
@jasonbosco
Copy link
Contributor Author

@dev2049 I just added docs for Typesense similar to the other vector stores: https://github.com/jasonbosco/langchain/blob/85b7c739518b928eebb8224fb82fbaf0c3c43010/docs/modules/indexes/vectorstores/examples/typesense.ipynb

@jasonbosco jasonbosco requested a review from dev2049 May 23, 2023 23:05
@dev2049 dev2049 added lgtm PR looks good. Use to confirm that a PR is ready for merging. and removed needs documentation PR needs to be updated with documentation labels May 24, 2023
@dev2049 dev2049 merged commit 9c4b43b into langchain-ai:master May 24, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Merged
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dev2049 dev2049 Awaiting requested review from dev2049

Assignees
No one assigned
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonbosco @dev2049