Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: stringify tool non-content blocks #24626

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

baskaryan
Copy link
Collaborator

@baskaryan baskaryan commented Jul 24, 2024

Slightly breaking bugfix. Shouldn't cause too many issues since no models would be able to handle non-content block ToolMessage.content anyways.

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 10:48pm

@baskaryan baskaryan marked this pull request as ready for review July 31, 2024 22:16
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 31, 2024
@baskaryan baskaryan changed the title rfc: stringify tool non-content blocks core[patch]: stringify tool non-content blocks Jul 31, 2024
@dosubot dosubot bot added Ɑ: core Related to langchain-core 🤖:improvement Medium size change to existing code to handle new use-cases labels Jul 31, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 31, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 31, 2024
@baskaryan baskaryan merged commit 25b93cc into master Jul 31, 2024
97 checks passed
@baskaryan baskaryan deleted the bagatur/stringify_non_content_blocks branch July 31, 2024 23:42
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
Slightly breaking bugfix. Shouldn't cause too many issues since no
models would be able to handle non-content block ToolMessage.content
anyways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: core Related to langchain-core 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants