Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure National Cloud authentication using token (RBAC) (Generated by Ana - AI SDE) #25843

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Fix Azure National Cloud authentication using token (RBAC) (Generated by Ana - AI SDE) #25843

merged 7 commits into from
Dec 16, 2024

Conversation

ana-ai-sde
Copy link
Contributor

This pull request addresses the issue with authenticating Azure National Cloud using token (RBAC) in the AzureSearch vectorstore implementation.

Changes

  • Modified the _get_search_client method in azuresearch.py to pass additional_search_client_options to the SearchIndexClient instance.

Implementation Details

The patch updates the SearchIndexClient initialization to include the additional_search_client_options parameter:

index_client: SearchIndexClient = SearchIndexClient(
    endpoint=endpoint,
    credential=credential,
    user_agent=user_agent,
    **additional_search_client_options
)

This change allows the audience parameter to be correctly passed when using Azure National Cloud, fixing the authentication issues with GovCloud & RBAC.

This patch was generated by Ana - AI SDE, an AI-powered software development assistant.

This is a fix for Issue 25823

@ana-ai-sde
Fix: Pass additional_search_client_options to SearchIndexClient in Az…
3bff6ff 
…ureSearch (Generated by Ana - AI SDE)
@ana-ai-sde
Merge pull request #1 from ana-ai-sde/ana-fix-213134278fdbh2390-21389
0e059ab 
Fix Azure National Cloud authentication using token (RBAC) (Generated by Ana - AI SDE)
@vercel Vercel
Copy link

vercel bot commented Aug 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 6:22pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. community Related to langchain-community Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Aug 29, 2024
@ana-ai-sde
Fix: Restrict strict parameter usage to BaseTool instances in convert…
7c63dae 
…_to_openai_function (Generated by Ana - AI SDE)
@ana-ai-sde
Revert "Fix: Restrict strict parameter usage to BaseTool instances in…
2132422 
… convert_to_openai_function (Generated by Ana - AI SDE)"

This reverts commit 7c63dae.
@ccurme ccurme self-assigned this Aug 29, 2024
@ccurme ccurme marked this pull request as draft August 29, 2024 13:20
@ccurme
Copy link
Collaborator

ccurme commented Aug 29, 2024

Marking draft pending discussion in #25823

@ccurme ccurme marked this pull request as ready for review December 16, 2024 17:49
@ccurme ccurme enabled auto-merge (squash) December 16, 2024 17:49
@ccurme ccurme merged commit ebab2ea into langchain-ai:master Dec 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ccurme ccurme

Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
PR Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ana-ai-sde @ccurme