Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrations[patch]: remove non-required chat param defaults #26730

Merged
merged 6 commits into from
Jan 6, 2025
Merged

integrations[patch]: remove non-required chat param defaults #26730

merged 6 commits into from
Jan 6, 2025

Conversation

baskaryan
Copy link
Collaborator

anthropic:

  • max_retries

openai:

  • n
  • temperature
  • max_retries

fireworks

  • temperature

groq

  • n
  • max_retries
  • temperature

mistral

  • max_retries
  • timeout
  • max_concurrent_requests
  • temperature
  • top_p
  • safe_mode

@efriis efriis added the partner label Sep 20, 2024
@efriis efriis self-assigned this Sep 20, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 20, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 10:22pm

@dosubot dosubot bot added langchain Related to the langchain package 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Sep 20, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 6, 2025
@efriis efriis enabled auto-merge (squash) January 6, 2025 22:04
@efriis efriis disabled auto-merge January 6, 2025 22:04
@efriis efriis enabled auto-merge (squash) January 6, 2025 22:24
@efriis efriis merged commit 3d7ae8b into master Jan 6, 2025
88 checks passed
@efriis efriis deleted the bagatur/rm_optional_defaults branch January 6, 2025 22:26
efriis added a commit that referenced this pull request Jan 6, 2025
@efriis
Revert "integrations[patch]: remove non-required chat param defaults (#…
bd4d77d 
…26730)"

This reverts commit 3d7ae8b.
@efriis efriis mentioned this pull request Jan 6, 2025
Merged
efriis added a commit that referenced this pull request Jan 6, 2025
@efriis
Revert "integrations[patch]: remove non-required chat param defaults" (…
187131c 
…#29048)

Reverts #26730

discuss best way to release default changes (esp openai temperature)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees

@efriis efriis

Labels
langchain Related to the langchain package lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs partner size:M This PR changes 30-99 lines, ignoring generated files.
Projects
PR Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baskaryan @efriis