Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Fix validation error in SettingsConfigDict across multiple Langchain modules #26852

Merged

Conversation

Raj725
Copy link
Contributor

@Raj725 Raj725 commented Sep 25, 2024

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 0:16am

@eyurtsev eyurtsev self-assigned this Sep 25, 2024
@eyurtsev
Copy link
Collaborator

@Raj725 this looks good. Let me know whenever PR is ready for review

@Raj725
Copy link
Contributor Author

Raj725 commented Sep 25, 2024

@Raj725 this looks good. Let me know whenever PR is ready for review

@eyurtsev I kept this in draft because I haven't tested it. However, I did test similar changes I made for SharePointLoader/_O365Settings in this PR: #26851.

@Raj725 Raj725 marked this pull request as ready for review September 25, 2024 13:56
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. community Related to langchain-community Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Sep 25, 2024
@eyurtsev
Copy link
Collaborator

It looks reasonable to me

@eyurtsev eyurtsev merged commit 51c4393 into langchain-ai:master Sep 25, 2024
31 checks passed
Sheepsta300 pushed a commit to Sheepsta300/langchain that referenced this pull request Oct 1, 2024
…ultiple Langchain modules (langchain-ai#26852)

- **Description:** This pull request addresses the validation error in
`SettingsConfigDict` due to extra fields in the `.env` file. The issue
is prevalent across multiple Langchain modules. This fix ensures that
extra fields in the `.env` file are ignored, preventing validation
errors.
  **Changes include:**
    - Applied fixes to modules using `SettingsConfigDict`.

- **Issue:** NA, similar
langchain-ai#26850
- **Dependencies:** NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants