Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Add configurable VisualFeatures to the AzureAiServicesImageAnalysisTool #27444

Merged
merged 9 commits into from
Dec 16, 2024

Conversation

Sheepsta300
Copy link
Contributor

Thank you for contributing to LangChain!

  • PR title: community: Add configurable VisualFeatures to the AzureAiServicesImageAnalysisTool

  • PR message:

    • Description: The AzureAiServicesImageAnalysisTool is a good service and utilises the Azure AI Vision package under the hood. However, since the creation of this tool, new VisualFeatures have been added to allow the user to request other image specific information to be returned. Currently, the tool offers neither configuration of which features should be return nor does it offer any newer feature types. The aim of this PR is to address this and expose more of the Azure Service in this integration.
    • Dependencies: no new dependencies in the main class file, azure.ai.vision.imageanalysis added to extra test dependencies file.
  • Add tests and docs: If you're adding a new integration, please include

    1. Although no tests exist for already implemented Azure Service tools, I've created 3 unit tests for this class that test initialisation and credentials, local file analysis and a test for the new changes/ features option.
  • Lint and test: All linting has passed.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 17, 2024
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 6:28pm

@dosubot dosubot bot added the community Related to langchain-community label Oct 17, 2024
@efriis
Copy link
Member

efriis commented Oct 21, 2024

don't love adding a beta dependency to testing deps - is there a reason the underlying sdk needs to be a beta release?

Azure is doing some work in the langchain-ai/langchain-azure package - it's possible some of these integrations could move to integration packages over there.

@Sheepsta300
Copy link
Contributor Author

It seems that a stable release for azure.ai.vision.imageanalysis was released 4 days ago, so I'm able to update the test deps to stop using the beta-dependency. Before this, the package was still in beta unfortunately.

As for moving the integration to langchain-azure, I'd be happy to move it to wherever is most convenient. However, I'll speak with our Azure clients first.

@ccurme ccurme enabled auto-merge (squash) December 16, 2024 18:27
@ccurme ccurme merged commit 580a8d5 into langchain-ai:master Dec 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants