Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: make sure tool input keys won't be modified during following process #27862

Closed

Conversation

JetDrag
Copy link
Contributor

@JetDrag JetDrag commented Nov 2, 2024

Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2024 3:05am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Nov 2, 2024
@JetDrag JetDrag force-pushed the core-prevent_tool_input_modified branch 3 times, most recently from b1b4d73 to 0c436b2 Compare November 2, 2024 17:14
@JetDrag JetDrag changed the title core: prevent tool input to be modified core: make sure tool input keys won't be modified during following process Nov 2, 2024
…ocess, to prevent problems when there's no args schema.
@JetDrag JetDrag force-pushed the core-prevent_tool_input_modified branch from 0c436b2 to 2541857 Compare November 3, 2024 03:04
@JetDrag
Copy link
Contributor Author

JetDrag commented Nov 12, 2024

Hi @baskaryan , do you have any time to review this core fix PR? The impact scope is somewhat large.

@JetDrag
Copy link
Contributor Author

JetDrag commented Nov 16, 2024

Hi @efriis , do you have any time to review this core fix PR? The impact scope is somewhat large.

@rubepocegeka
Copy link

When will this be merged with mastser, it is a crucial fix for the Langgraph environment.

@JetDrag
Copy link
Contributor Author

JetDrag commented Dec 5, 2024

Hi @efriis, do you have time to review this core fix PR as soon as possible? The impact scope is somewhat large.

@ccurme
Copy link
Collaborator

ccurme commented Dec 18, 2024

Could you please add a minimal reproducible example of the problem as a test?

I cannot replicate the problem in the example commented in one of the issues (here, from July).

@ccurme
Copy link
Collaborator

ccurme commented Dec 19, 2024

Thanks very much for the root-causing and comments here. Closing in favor of #28824. Please add your feedback there.

@ccurme ccurme closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

TypeError('Object of type CallbackManagerForToolRun is not JSON serializable') on Coder agent
4 participants