community: Add support for SAP HANA Vector hnsw index creation #27884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
community
|
Hi @baskaryan, could you please take a look at this PR and let us know if anything is missing? |
|
Sorry for bumping this PR again but we would really appreciate some kind of response on how to continue. @efriis or @eyurtsev could you give us a short response? Do we need to follow the new guidelines for community packages/integrations? |
efriis
approved these changes
Dec 5, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Added support for creating indexes in the SAP HANA Vector engine.
Changes:
create_hnsw_indexinhanavector.pythat enables the creation of indexes for SAP HANA Vector._process_filter_objectfunction and change the array argument to a placeholder in the similarity search SQL statement.