Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: fix some features on Naver ChatModel & embedding model #28228

Conversation

hyper-clova
Copy link
Contributor

@hyper-clova hyper-clova commented Nov 20, 2024

Description

  • adding stopReason to response_metadata to call stream and astream
  • excluding NCP_APIGW_API_KEY input required validation
  • to remove warning Field "model_name" has conflict with protected namespace "model_".

cc. @vbarda

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 20, 2024
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 8:14am

@dosubot dosubot bot added community Related to langchain-community Ɑ: embeddings Related to text embedding models module labels Nov 20, 2024
@hyper-clova hyper-clova changed the title community: fix some features on Naver ChatModel & mbedding model . community: fix some features on Naver ChatModel & mbedding model Nov 20, 2024
@hyper-clova hyper-clova changed the title community: fix some features on Naver ChatModel & mbedding model community: fix some features on Naver ChatModel & embedding model Nov 20, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! any interest in deprecating this and moving to a self-managed partner package via this guide?

very similar to your original PR, just would be in a repo under your management instead of ours: https://python.langchain.com/docs/contributing/how_to/integrations/

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Nov 20, 2024
@efriis efriis merged commit 218b4e0 into langchain-ai:master Nov 20, 2024
18 checks passed
@efriis
Copy link
Member

efriis commented Nov 20, 2024

(this is a new guide by the way - sorry it wasn't available during the initial integration - we're learning as a team!)

@hyper-clova
Copy link
Contributor Author

@efriis , I waited for the updates because the docs were in draft version at the time you left the comments. Now I see the final version and will look into it.

For clarification, do you have plan for deprecating langchain-community then? (if yes, in what is the expected timeline?)

From our perspective, we just announced to our users about our integration availability this month, so we want to maintain in this way for a moment. (Also we have several upcoming minor fixes, wishing to be updated via community package like this issue.)

But as we are preparing a new API spec in next year (about 2Q), it might be ok then to migrating to a self-managed partner package as you mentioned. Would like to hear your thought on whether it is ok with this timeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants