-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: fix some features on Naver ChatModel & embedding model #28228
community: fix some features on Naver ChatModel & embedding model #28228
Conversation
community[patch]: add stopReason to response_metadata to call stream 2
… protected namespace "model_".
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey! any interest in deprecating this and moving to a self-managed partner package via this guide?
very similar to your original PR, just would be in a repo under your management instead of ours: https://python.langchain.com/docs/contributing/how_to/integrations/
(this is a new guide by the way - sorry it wasn't available during the initial integration - we're learning as a team!) |
@efriis , I waited for the updates because the docs were in draft version at the time you left the comments. Now I see the final version and will look into it. For clarification, do you have plan for deprecating langchain-community then? (if yes, in what is the expected timeline?) From our perspective, we just announced to our users about our integration availability this month, so we want to maintain in this way for a moment. (Also we have several upcoming minor fixes, wishing to be updated via community package like this issue.) But as we are preparing a new API spec in next year (about 2Q), it might be ok then to migrating to a self-managed partner package as you mentioned. Would like to hear your thought on whether it is ok with this timeline. |
Description
cc. @vbarda