core[patch]: support final AIMessage responses in tool_example_to_messages
#28267
+45
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This reverts commit b270ffb.
ccurme
commented
Nov 21, 2024
| @@ -495,20 +495,25 @@ def convert_to_openai_tool( | |||
|
|
|||
|
|
|||
| def tool_example_to_messages( | |||
There was a problem hiding this comment.
This utility was added 8 months ago but is not documented. Thoughts on retroactively marking it @beta?
There was a problem hiding this comment.
Sure I don't mind!
hmm tool calls are also limited to BaseModel / should probably supported typed dicts
There was a problem hiding this comment.
Marked beta
Looked into supporting TypedDict but we need a way of getting the tool name from an instance of TypedDict
from typing_extensions import TypedDict
class Apple(TypedDict):
color: str
tool_call = Apple(color="red")
tool_call.__class__.__name__'dict'
eyurtsev
approved these changes
Nov 21, 2024
dosubot
bot
added
the
lgtm
eyurtsev
reviewed
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a test test_structured_few_shot_examples in standard integration tests that implements a version of tool-calling few shot examples that works with ~all tested providers. The formulation supported by ~all providers is:
human message, tool call, tool message, AI reponse.Here we update
langchain_core.utils.function_calling.tool_example_to_messagesto support this formulation.The
tool_example_to_messagesutil is undocumented outside of our API reference. IMO, if we are testing that this function works across all providers, it can be helpful to feature it in our guides. The structured few-shot examples we document at the moment require users to implement this function and can be simplified.