Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partners: add 'model' alias for consistency in embedding classes #28374

Merged

Conversation

manuelescobar-dev
Copy link
Contributor

Description: This PR introduces a model alias for the embedding classes that contain the attribute model_name, to ensure consistency across the codebase, as suggested by a moderator in a previous PR. The change aligns the usage of attribute names across the project (see for example here).
Issue: This PR addresses the suggestion from the review of issue #28269.
Dependencies: None

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 10:23pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: embeddings Related to text embedding models module labels Nov 27, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 27, 2024
@eyurtsev
Copy link
Collaborator

Needs this:

    model_config = ConfigDict(
        populate_by_name=True,
    )```

otherwise it's a breaking change. I'll add

@@ -8,7 +10,7 @@ class FastEmbedSparse(SparseEmbeddings):

def __init__(
self,
model_name: str = "Qdrant/bm25",
model_name: str = Field(default="Qdrant/bm25", alias="model"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a pydantic model -- that's not going to work, so revering changes here

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 11, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 11, 2024
@efriis efriis enabled auto-merge (squash) December 13, 2024 22:23
@efriis efriis merged commit af2e0a7 into langchain-ai:master Dec 13, 2024
19 checks passed
@manuelescobar-dev manuelescobar-dev deleted the partners-add-model-alias branch December 14, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants