-
Notifications
You must be signed in to change notification settings - Fork 15.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
partners: add 'model' alias for consistency in embedding classes #28374
Merged
efriis
merged 8 commits into
langchain-ai:master
from
manuelescobar-dev:partners-add-model-alias
Dec 13, 2024
Merged
partners: add 'model' alias for consistency in embedding classes #28374
efriis
merged 8 commits into
langchain-ai:master
from
manuelescobar-dev:partners-add-model-alias
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
Ɑ: embeddings
Related to text embedding models module
labels
Nov 27, 2024
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Nov 27, 2024
Needs this:
|
eyurtsev
reviewed
Dec 11, 2024
@@ -8,7 +10,7 @@ class FastEmbedSparse(SparseEmbeddings): | |||
|
|||
def __init__( | |||
self, | |||
model_name: str = "Qdrant/bm25", | |||
model_name: str = Field(default="Qdrant/bm25", alias="model"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a pydantic model -- that's not going to work, so revering changes here
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Dec 11, 2024
eyurtsev
approved these changes
Dec 11, 2024
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ɑ: embeddings
Related to text embedding models module
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
size:XS
This PR changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR introduces a
model
alias for the embedding classes that contain the attributemodel_name
, to ensure consistency across the codebase, as suggested by a moderator in a previous PR. The change aligns the usage of attribute names across the project (see for example here).Issue: This PR addresses the suggestion from the review of issue #28269.
Dependencies: None