ollama[patch]: permit streaming for tool calls #28654
Merged
+2
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28543
Ollama recently released support for streaming tool calls. Previously we would override the
stream
parameter if tools were passed in.Covered in standard tests here:
langchain/libs/standard-tests/langchain_tests/integration_tests/chat_models.py
Lines 893 to 897 in c1d348e
Before, the test generates one message chunk:
After, it generates two (tool call in one, response metadata in another):