anthropic: less pydantic for client #28823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:S
efriis
commented
Dec 19, 2024
Comment on lines
-544
to
-546
| _client: anthropic.Client = PrivateAttr(default=None) # type: ignore[assignment] | ||
| _async_client: anthropic.AsyncClient = PrivateAttr(default=None) # type: ignore[assignment] | ||
|
|
There was a problem hiding this comment.
these create mypy issues because we want the type to be not-None, but by default it's None
| return client_params | ||
|
|
||
| @cached_property | ||
| def _client(self) -> anthropic.Client: |
There was a problem hiding this comment.
if we don't have it at top-level, it doesn't matter, and also removes a validator
eyurtsev
approved these changes
Dec 19, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.