Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): Add WandbTracer #4521

Merged
merged 32 commits into from
Jun 1, 2023

Conversation

parambharat
Copy link
Contributor

@parambharat parambharat commented May 11, 2023

WandbTracer

This PR adds the WandbTracer and deprecates the existing WandbCallbackHandler.

Added an example notebook under the docs section alongside the LangchainTracer
Here's an example colab with the same notebook and the trace generated from the colab run

Who can review?

Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:
@agola11

@dev2049 dev2049 requested a review from agola11 May 11, 2023 18:31
@parambharat parambharat marked this pull request as ready for review May 17, 2023 13:27
Copy link
Collaborator

@agola11 agola11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defer to you on the the conversion logic, otherwise some comments

tests/integration_tests/callbacks/test_wandb_tracer.py Outdated Show resolved Hide resolved
langchain/callbacks/tracers/wandb.py Outdated Show resolved Hide resolved
langchain/callbacks/tracers/wandb.py Outdated Show resolved Hide resolved
langchain/callbacks/tracers/wandb.py Outdated Show resolved Hide resolved
docs/ecosystem/agent_with_wandb_tracing.ipynb Outdated Show resolved Hide resolved
@parambharat
Copy link
Contributor Author

@agola11 : Thanks for the review and comments. I have incorporated all of your review suggestions and resolved the comments. Let me know if this looks good. I will add the serialized logging to the trace view once the serialization is finalized.

…tracer

# Conflicts:
#	langchain/callbacks/__init__.py
#	poetry.lock
#	pyproject.toml
@agola11
Copy link
Collaborator

agola11 commented May 24, 2023

cc @dev2049

@dev2049 dev2049 added 03 enhancement Enhancement of existing functionality lgtm PR looks good. Use to confirm that a PR is ready for merging. callbacks labels Jun 1, 2023
@dev2049 dev2049 merged commit 22603d1 into langchain-ai:master Jun 1, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
# WandbTracer
This PR adds the `WandbTracer` and deprecates the existing
`WandbCallbackHandler`.

Added an example notebook under the docs section alongside the
`LangchainTracer`
Here's an example
[colab](https://colab.research.google.com/drive/1pY13ym8ENEZ8Fh7nA99ILk2GcdUQu0jR?usp=sharing)
with the same notebook and the
[trace](https://wandb.ai/parambharat/langchain-tracing/runs/8i45cst6)
generated from the colab run


Co-authored-by: Bharat Ramanathan <ramanathan.parameshwaran@gohuddl.com>
Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
@parambharat parambharat deleted the wandb/tracer branch June 19, 2023 05:35
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 enhancement Enhancement of existing functionality lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants