Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bilibili #4860

Merged
merged 2 commits into from
May 18, 2023
Merged

Fix bilibili #4860

merged 2 commits into from
May 18, 2023

Conversation

yuekaizhang
Copy link
Contributor

@yuekaizhang yuekaizhang commented May 17, 2023 •
edited
Loading

Fix bilibili api import error

bilibili-api package is depracated and there is no sync module.

Fixes #2673 #2724

Before submitting

Who can review?

Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:
@vowelparrot @liaokongVFX

@yuekaizhang yuekaizhang changed the title Fix Fix bilibili May 17, 2023
@eyurtsev eyurtsev added the Ɑ: agent Related to agents module label May 17, 2023
@eyurtsev
Copy link
Collaborator

For reference -- This is the package pypi package looks fine: https://pypi.org/project/bilibili-api-python/

@eyurtsev eyurtsev added lgtm PR looks good. Use to confirm that a PR is ready for merging. and removed Ɑ: agent Related to agents module labels May 18, 2023
@eyurtsev eyurtsev merged commit 1ed4228 into langchain-ai:master May 18, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Merged
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuekaizhang @eyurtsev