-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved query, print & exception handling in REPL Tool #4997
Conversation
@vowelparrot kindly check this pull request. |
Made a small change to make sure backticks(`) & python are not removed, if they are present inside of a code (such as print statements), using regex. Also added a test case to verify the same. The code is ready for review/merge now (@vowelparrot , @dev2049 ). |
So this check fails because the python |
I just found out that it is possible to solve this problem by modifying the following function in
But this required me to Reference: plasma-umass/scalene#544 (comment) |
We don't want to add additional depenencies unless absolutely necessary. If it works for python versions < 3.8, you can try importing and then throw a more helpful import error saying to either use python version > 3.9 or pip install the unparser. For test cases, you could do
To test the unparser specifically, we have "extended_tests" that are run with additional dependencies. (I think you can stack marks but if that's not the case we can remove the skipif and just return a pass if the version isn't 3.8 or lower)
Then add the unparser to the |
Ok sure, I can do that. Let me revert my last commit, and make the changes you mentioned. Thanks for your reply. |
This reverts commit 1a82779.
@vowelparrot I have skipped <3.9 python versions for the ast_repl test cases as you mentioned (thanks for helping me out). You can merge this PR now (it should pass all test cases). |
Update to pull request #3215
Summary:
For more details, view the previous pull request.