Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Weather Loader #5056

Merged
merged 16 commits into from
May 23, 2023
Merged

Adding Weather Loader #5056

merged 16 commits into from
May 23, 2023

Conversation

iamadhee
Copy link
Contributor

Adding Weather Loader

Before submitting

Below is the recording of the module testing:
https://github.com/hwchase17/langchain/assets/69910091/2b179eec-1421-4509-9ac8-89f57f739ba6

Who can review?

@eyurtsev

@eyurtsev eyurtsev self-requested a review May 22, 2023 16:40
@eyurtsev
Copy link
Collaborator

@iamadhee code is looking pretty good! I added a few minor comments to avoid overloading load. I'd recommend providing an implementation for lazy_load by default rather than for load. if you're able it would be nice to include a test. Ideally a test that mocks the client response and does not use the network to fetch data.

@iamadhee
Copy link
Contributor Author

@iamadhee code is looking pretty good! I added a few minor comments to avoid overloading load. I'd recommend providing an implementation for lazy_load by default rather than for load. if you're able it would be nice to include a test. Ideally a test that mocks the client response and does not use the network to fetch data.

Hey @eyurtsev, I have added the lazy_load method, as discussed.

eyurtsev
eyurtsev reviewed May 22, 2023
View reviewed changes
langchain/document_loaders/weather.py Outdated Show resolved Hide resolved
langchain/document_loaders/weather.py Outdated Show resolved Hide resolved
langchain/document_loaders/weather.py Outdated Show resolved Hide resolved
langchain/document_loaders/weather.py Outdated Show resolved Hide resolved
@iamadhee
Copy link
Contributor Author

@eyurtsev Not a problem, made the necessary changes and tested out the code.

@dev2049 dev2049 added the 03 enhancement Enhancement of existing functionality label May 22, 2023
@dev2049
Copy link
Contributor

dev2049 commented May 22, 2023

could we add an example notebook

@iamadhee
Copy link
Contributor Author

@dev2049 Added the sample notebook as discussed

@dev2049 dev2049 added maintainer-to-merge lgtm PR looks good. Use to confirm that a PR is ready for merging. labels May 23, 2023
eyurtsev
eyurtsev approved these changes May 23, 2023
View reviewed changes
langchain/document_loaders/weather.py Outdated Show resolved Hide resolved
@dev2049 dev2049 merged commit 68f0d45 into langchain-ai:master May 23, 2023
leo-gan
leo-gan reviewed May 24, 2023
View reviewed changes
Copy link
Collaborator

@leo-gan leo-gan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit: error handling on the import. Otherwise, lgtm.

langchain/document_loaders/weather.py Outdated Show resolved Hide resolved
vowelparrot pushed a commit that referenced this pull request May 24, 2023
@iamadhee @tylerhutcherson
@dev2049 @vowelparrot
Adding Weather Loader (#5056)
78eca3f 

Co-authored-by: Tyler Hutcherson <tyler.hutcherson@redis.com>
Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Merged
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo-gan leo-gan leo-gan left review comments

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees
No one assigned
Labels
03 enhancement Enhancement of existing functionality lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamadhee @eyurtsev @dev2049 @leo-gan