Add Joplin document loader #5153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-gan
reviewed
May 23, 2023
langchain/document_loaders/joplin.py
Outdated
| "access_token", "JOPLIN_ACCESS_TOKEN" | ||
| ) | ||
| self.get_note = ( | ||
| f"http://localhost:41184/notes?token={self.access_token}&fields=id,parent_id,title,body,created_time,updated_time&page=" |
There was a problem hiding this comment.
Most probably, the port (it is 41184) is configurable. Maybe to add it as __init__ param with default as 41184?
There was a problem hiding this comment.
Thanks @leo-gan , good idea. Although AFAIK it's not configurable in Joplin at the moment, perhaps if someone tries tunneling tricks they would need to adjust the host/port. Added.
dev2049
added
the
Ɑ: doc loader
Merged
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
# Add Joplin document loader [Joplin](https://joplinapp.org/) is an open source note-taking app. Joplin has a [REST API](https://joplinapp.org/api/references/rest_api/) for accessing its local database. The proposed `JoplinLoader` uses the API to retrieve all notes in the database and their metadata. Joplin needs to be installed and running locally, and an access token is required. - The PR includes an integration test. - The PR includes an example notebook. --------- Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Joplin document loader
Joplin is an open source note-taking app.
Joplin has a REST API for accessing its local database. The proposed
JoplinLoaderuses the API to retrieve all notes in the database and their metadata. Joplin needs to be installed and running locally, and an access token is required.Who can review?
@eyurtsev