Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fauna Loader #5157

Merged
merged 11 commits into from
Jun 8, 2023
Merged

Fauna Loader #5157

merged 11 commits into from
Jun 8, 2023

Conversation

Shadid12
Copy link
Contributor

@Shadid12 Shadid12 commented May 24, 2023 •
edited
Loading

Following is the FaunaDB document loader for langchain.

How to use it

from langchain.document_loaders.fauna import FaunaLoader

loader = FaunaLoader("Item.all()", "<Field to Retrieve>", "<Fauna Secret>")
docs = loader.load()
print(docs)

@leo-gan
Copy link
Collaborator

leo-gan commented May 24, 2023

Is it possible to add some integration tests and an example into docs/modules/indexes/document_loaders/examples/? Thanks!

@dev2049 dev2049 added the 03 enhancement Enhancement of existing functionality label May 24, 2023
@hwchase17
Copy link
Contributor

+1 to @leo-gan 's comment, thanks for adding this! would love to get this in thursday, all thats missing is an example notebook

@dev2049 dev2049 added the Ɑ: doc loader Related to document loader module (not documentation) label May 24, 2023
@Shadid12 Shadid12 requested review from leo-gan and dev2049 May 25, 2023 04:19
eyurtsev
eyurtsev reviewed May 26, 2023
View reviewed changes
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shadid12 Looks pretty good to me! Thank you for the contribution it's much appreciated! I left a few minor comments

langchain/document_loaders/fauna.py Outdated Show resolved Hide resolved
tests/integration_tests/document_loaders/test_fauna.py Show resolved Hide resolved
langchain/document_loaders/fauna.py Show resolved Hide resolved
langchain/document_loaders/fauna.py Outdated Show resolved Hide resolved
@Shadid12 Shadid12 requested a review from eyurtsev May 31, 2023 17:58
eyurtsev
eyurtsev requested changes Jun 2, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
tests/integration_tests/document_loaders/test_fauna.py Show resolved Hide resolved
@Shadid12 Shadid12 requested a review from eyurtsev June 7, 2023 18:29
@hwchase17 hwchase17 changed the base branch from master to harrison/fauna-loader June 8, 2023 03:36
@hwchase17 hwchase17 merged commit 5faee4e into langchain-ai:harrison/fauna-loader Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo-gan leo-gan Awaiting requested review from leo-gan

@dev2049 dev2049 Awaiting requested review from dev2049

@eyurtsev eyurtsev Awaiting requested review from eyurtsev

Assignees
No one assigned
Labels
03 enhancement Enhancement of existing functionality Ɑ: doc loader Related to document loader module (not documentation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shadid12 @leo-gan @hwchase17 @eyurtsev @dev2049