Implemented appending arbitrary messages #5293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyurtsev
added
the
lgtm
|
@hwchase17 -- Proposal seems to add an abstract method to add a custom message which seems reasonable to me -- it looks like a more appropriate method for the base schema than add_ai_message or add_human_message. Waiting for your 👁️ |
eyurtsev
reviewed
May 26, 2023
| @@ -261,6 +266,10 @@ def add_user_message(self, message: str) -> None: | |||
| def add_ai_message(self, message: str) -> None: | |||
| """Add an AI message to the store""" | |||
|
|
|||
| @abstractmethod | |||
| def add_message(self, message: BaseMessage) -> None: | |||
There was a problem hiding this comment.
This seems reasonable to me. Looks more appropriate than add_ai_message or add_human_message for the lowest building block of chat history.
There was a problem hiding this comment.
went a step further now, got rid of all implementations of add_xx_message, instead using add_message in each subclass, and then noticed most had another method (usually append) with the same footprint, so got rid of those as well, much cleaner IMHO!
There was a problem hiding this comment.
i dont think this is super backwards compatible, can we raise NotImplementedError rather than have as abstract? that way if people subclassed it it doesnt break
hwchase17
approved these changes
May 29, 2023
|
Thanks @hwchase17 |
|
@amitmukh this has been merged and release and will allow you to override the regular append_message behaviour |
vowelparrot
pushed a commit
that referenced
this pull request
May 31, 2023
# Implemented appending arbitrary messages to the base chat message history, the in-memory and cosmos ones. <!-- Thank you for contributing to LangChain! Your PR will appear in our next release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. --> As discussed this is the alternative way instead of #4480, with a add_message method added that takes a BaseMessage as input, so that the user can control what is in the base message like kwargs. <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting <!-- If you're adding a new integration, include an integration test and an example notebook showing its use! --> ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: @hwchase17 --------- Co-authored-by: Harrison Chase <hw.chase.17@gmail.com>
Merged
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
# Implemented appending arbitrary messages to the base chat message history, the in-memory and cosmos ones. <!-- Thank you for contributing to LangChain! Your PR will appear in our next release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. --> As discussed this is the alternative way instead of langchain-ai#4480, with a add_message method added that takes a BaseMessage as input, so that the user can control what is in the base message like kwargs. <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting <!-- If you're adding a new integration, include an integration test and an example notebook showing its use! --> ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: @hwchase17 --------- Co-authored-by: Harrison Chase <hw.chase.17@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented appending arbitrary messages to the base chat message history, the in-memory and cosmos ones.
As discussed this is the alternative way instead of #4480, with a add_message method added that takes a BaseMessage as input, so that the user can control what is in the base message like kwargs.
Fixes # (issue)
Before submitting
Who can review?
Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:
@hwchase17