Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed passing creds to VertexAI LLM #5297

Merged
merged 1 commit into from
May 26, 2023

Conversation

lkuligin
Copy link
Collaborator

Fixed passing creds to VertexAI LLM

Fixes #5279

It looks like we should drop a type annotation for Credentials.

@lkuligin lkuligin force-pushed the fix_vertex_credentials branch from 2989259 to 6bf93ce Compare May 26, 2023 12:32
@lkuligin
Copy link
Collaborator Author

@hwchase17

@dev2049 dev2049 merged commit aa3c7b3 into langchain-ai:master May 26, 2023
@lkuligin lkuligin deleted the fix_vertex_credentials branch May 26, 2023 15:32
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
# Fixed passing creds to VertexAI LLM

Fixes  langchain-ai#5279 

It looks like we should drop a type annotation for Credentials.

Co-authored-by: Leonid Kuligin <kuligin@google.com>
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue Passing in Credential to VertexAI model
2 participants