Harrison/html splitter #5468
Merged
Harrison/html splitter #5468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# HtmlTextSplitter I am submitting a new HtmlTextSplitter class, which attempts to split text along HTML layout elements. This PR addresses the need for HTML text splitting functionality in the LangChain library. There are no additional dependencies required for this change. ## Examples An [example notebook](docs/modules/indexes/text_splitters/examples/html.ipynb) showing its use ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: - @vowelparrot --------- Co-authored-by: Harrison Chase <hw.chase.17@gmail.com>
eyurtsev
reviewed
May 31, 2023
| @@ -478,6 +478,45 @@ def __init__(self, **kwargs: Any): | |||
| super().__init__(separators=separators, **kwargs) | |||
|
|
|||
|
|
|||
| class HtmlTextSplitter(RecursiveCharacterTextSplitter): | |||
There was a problem hiding this comment.
This feels like a splitter that's similar conceptually to the code language splitters below (and to markdown, rst).
And it feels very different from SpacyTextSplitter or NLTKTextSplitter.
I don't have a strong opinion here, mostly wondering if it makes sense to keep a small number of core classes in the global namespace, and do the parameterization as part of the initializer when makes sense
vowelparrot
pushed a commit
that referenced
this pull request
May 31, 2023
Co-authored-by: David Revillas <26328973+r3v1@users.noreply.github.com>
Merged
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
Co-authored-by: David Revillas <26328973+r3v1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.