Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace enumerate with zip. #5527

Merged
merged 1 commit into from
May 31, 2023
Merged

Replace enumerate with zip. #5527

merged 1 commit into from
May 31, 2023

Conversation

ttsugriy
Copy link
Contributor

Replace enumerate with zip.

It's more idiomatic and slightly more readable.

@ttsugriy
Replace enumerate with zip.
14c92a0 
It's more idiomatic and slightly more readable.
@leo-gan
Copy link
Collaborator

leo-gan commented May 31, 2023

LGTM

hwchase17
hwchase17 approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 merged commit af41cdf into langchain-ai:master May 31, 2023
@ttsugriy ttsugriy deleted the patch-2 branch May 31, 2023 23:41
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Merged
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
@ttsugriy @Undertone0809
Replace enumerate with zip. (langchain-ai#5527)
171b82f 
# Replace enumerate with zip.

It's more idiomatic and slightly more readable.
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttsugriy @leo-gan @hwchase17