Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harrison/pipeline prompt #5540

Merged
merged 6 commits into from
Jun 4, 2023
Merged

Harrison/pipeline prompt #5540

merged 6 commits into from
Jun 4, 2023

Conversation

hwchase17
Copy link
Contributor

idea is to make prompts more composable


@property
def _prompt_type(self) -> str:
raise ValueError
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably eventually but ive been defaulting to not including until we figure out serialization

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay ive actually started using this for serialisation

Copy link
Collaborator

@nfcampos nfcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hwchase17 hwchase17 merged commit b904066 into master Jun 4, 2023
@hwchase17 hwchase17 deleted the harrison/pipeline-prompt branch June 4, 2023 21:29
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
idea is to make prompts more composable
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants