Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Messaging for APOC Procedure Failure in Neo4jGraph #5547

Conversation

guangchen811
Copy link
Contributor

Improve Error Messaging for APOC Procedure Failure in Neo4jGraph

This commit revises the error message provided when the 'apoc.meta.data()' procedure fails. Previously, the message simply instructed the user to install the APOC plugin in Neo4j. The new error message is more specific.

Also removed an unnecessary newline in the Cypher statement variable: node_properties_query.

Fixes #5545

Who can review?

This commit revises the error message provided when the 'apoc.meta.data()' procedure fails. Previously, the message simply instructed the user to install the APOC plugin in Neo4j. The new error message is more specific
@dev2049
Copy link
Contributor

dev2049 commented Jun 1, 2023

thanks @guangchen811!

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - thanks!

@hwchase17 hwchase17 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 3, 2023
@hwchase17 hwchase17 merged commit 3e45b83 into langchain-ai:master Jun 3, 2023
@guangchen811 guangchen811 deleted the Improve-APOC-Procedure-Error-Messaging branch June 7, 2023 15:38
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
…gchain-ai#5547)

## Improve Error Messaging for APOC Procedure Failure in Neo4jGraph

This commit revises the error message provided when the
'apoc.meta.data()' procedure fails. Previously, the message simply
instructed the user to install the APOC plugin in Neo4j. The new error
message is more specific.

Also removed an unnecessary newline in the Cypher statement variable:
`node_properties_query`.

Fixes langchain-ai#5545 

## Who can review?
  - @vowelparrot
  - @dev2049
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Improve Error Messaging When APOC Procedures Fail in Neo4jGraph
3 participants