Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bedrock boto3 client instantiation #5574

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

seanpmorgan
Copy link
Contributor

#5523 has a small bug if client was not passed in constructor

Who can review?

Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:

@seanpmorgan
Copy link
Contributor Author

cc @3coins

@dev2049
Copy link
Contributor

dev2049 commented Jun 1, 2023

thanks @seanpmorgan!

@dev2049 dev2049 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 1, 2023
@3coins
Copy link
Contributor

3coins commented Jun 1, 2023

@seanpmorgan
Thanks for working on this. Tested that this works ok in both scenarios.

@dev2049 dev2049 merged commit 8441cff into langchain-ai:master Jun 1, 2023
@seanpmorgan seanpmorgan deleted the fix-bedrock branch June 1, 2023 19:35
@seanpmorgan seanpmorgan changed the title Fix bedrock auth validation Fix bedrock boto3 client instatiation Jun 2, 2023
@seanpmorgan seanpmorgan changed the title Fix bedrock boto3 client instatiation Fix bedrock boto3 client instantiation Jun 2, 2023
dev2049 pushed a commit that referenced this pull request Jun 2, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
langchain-ai#5523 has a small bug if
client was not passed in constructor
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants