Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing client+namespace in favor of collection #5610

Merged
merged 2 commits into from
Jun 3, 2023
Merged

removing client+namespace in favor of collection #5610

merged 2 commits into from
Jun 3, 2023

Conversation

P-E-B
Copy link
Contributor

@P-E-B P-E-B commented Jun 2, 2023

removing client+namespace in favor of collection for an easier instantiation and to be similar to the typescript library

@dev2049

hwchase17
hwchase17 approved these changes Jun 3, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@hwchase17 hwchase17 merged commit 92f2182 into langchain-ai:master Jun 3, 2023
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
@P-E-B @Undertone0809
removing client+namespace in favor of collection (langchain-ai#5610)
5a3f33a 
removing client+namespace in favor of collection for an easier
instantiation and to be similar to the typescript library

@dev2049
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P-E-B @hwchase17