Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SingleStoreDB Vector Store #5619

Merged
merged 14 commits into from
Jun 8, 2023
Merged

Added SingleStoreDB Vector Store #5619

merged 14 commits into from
Jun 8, 2023

Conversation

volodymyr-memsql
Copy link
Contributor

@volodymyr-memsql volodymyr-memsql commented Jun 2, 2023

  • Added SingleStoreDB vector store, which is a wrapper over the SingleStore DB database, that can be used as a vector storage and has an efficient similarity search.
  • Added integration tests for the vector store
  • Added jupyter notebook with the example

@dev2049

@dev2049 dev2049 added 03 enhancement Enhancement of existing functionality Ɑ: vector store Related to vector store module labels Jun 2, 2023
@volodymyr-memsql volodymyr-memsql marked this pull request as ready for review June 6, 2023 12:54
@volodymyr-memsql
Copy link
Contributor Author

@leo-gan, @hwchase17, could you please check it again? Thank you!

@@ -347,6 +358,11 @@ class VectorStoreRetriever(BaseRetriever, BaseModel):
vectorstore: VectorStore
search_type: str = "similarity"
search_kwargs: dict = Field(default_factory=dict)
allowed_search_types: ClassVar[Collection[str]] = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id prefer not to do this in this pr - if we do this, should be a separate pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i think probably fine

@hwchase17 hwchase17 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 8, 2023
@hwchase17 hwchase17 merged commit a154990 into langchain-ai:master Jun 8, 2023
@volodymyr-memsql volodymyr-memsql deleted the add_singlestoredb_vectorstore branch June 16, 2023 11:19
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
- Added `SingleStoreDB` vector store, which is a wrapper over the
SingleStore DB database, that can be used as a vector storage and has an
efficient similarity search.
- Added integration tests for the vector store
- Added jupyter notebook with the example

@dev2049

---------

Co-authored-by: Volodymyr Tkachuk <vtkachuk-ua@singlestore.com>
Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
Co-authored-by: Harrison Chase <hw.chase.17@gmail.com>
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 enhancement Enhancement of existing functionality lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants