Fix serialization issue with W&B #5693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parambharat how does this look to you? |
Hi @jjzhuo , can you share an example of where you are seeing this ? A colab perhaps ? |
parambharat
suggested changes
Jun 5, 2023
langchain/callbacks/tracers/wandb.py
Outdated
| @@ -79,7 +85,7 @@ def _convert_chain_run_to_wb_span(trace_tree: Any, run: Run) -> trace_tree.Span: | |||
|
|
|||
| def _convert_tool_run_to_wb_span(trace_tree: Any, run: Run) -> trace_tree.Span: | |||
| base_span = _convert_run_to_wb_span(trace_tree, run) | |||
| base_span.results = [trace_tree.Result(inputs=run.inputs, outputs=run.outputs)] | |||
| base_span.results = [trace_tree.Result(inputs=serialize_inputs(run.inputs), outputs=run.outputs)] | |||
There was a problem hiding this comment.
@jjzhuo this should be _serialized_inputs
|
@parambharat The screenshot is from the Weights and Biases website. You can reproduce it by adding a RetrievalQA in this notebook: |
|
@jjzhuo , Thanks you for the fix. I have verified that the new @hwchase17 , This LGTM. |
hwchase17
added
the
lgtm
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
The chain input_documents are not displaying properly in W&B, due to serialization issue: <img width="1164" alt="Screenshot 2023-06-04 at 11 58 26 AM" src="https://github.com/hwchase17/langchain/assets/134809928/f31f14f6-0935-4cca-9913-6760cd40eadf"> --------- Co-authored-by: Harrison Chase <hw.chase.17@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chain input_documents are not displaying properly in W&B, due to serialization issue: