-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base RunEvaluator Chain #5750
Base RunEvaluator Chain #5750
Conversation
b4fc0e3
to
9ce74cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a few questions about class hierarchy and how this relates to the sdk but we can chat tmrw. Otherwise looks good
return self.parse(text) | ||
|
||
|
||
class RunEvaluator(Chain): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't this clash with RunEvaluator from the sdk? Also most (all?) subclasses of Chain
end with Chain
, i.e. RunEvaluatorChain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I'm a bit confused here. Should this just be a subclass of langchainplus_sdk.evaluation.evaluator.RunEvaluator
? It implements evaluate_run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should! my oversight - will rename and inherit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like there are a ton of errors in this notebook. Is this expected? Also, should we move this out of experimental?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can use da Vinci instead - I think previously the model hallucinated but a recent push made them parsing errors
feedback = self.output_parser.parse_chain_output(chain_output) | ||
return {"feedback": feedback} | ||
|
||
def evaluate_run( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having async support might be important here so we can run evals faster/concurrently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya I agree
4bf985f
to
658cae0
Compare
658cae0
to
7ba8f06
Compare
Clean up a bit and only implement the QA and reference free implementations from langchain-ai#5618
Clean up a bit and only implement the QA and reference free implementations from #5618