Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unnecessary backslash escaping for backticks in python #5751

Conversation

spazm
Copy link
Contributor

@spazm spazm commented Jun 5, 2023

Fixed python deprecation warning:
DeprecationWarning: invalid escape sequence '`'

backticks (`) do not have special meaning in python strings and should not be escaped.

-- @spazm on twitter

Who can review:

@nfcampos ported this change from javascript, @hwchase17 wrote the original STRUCTURED_FORMAT_INSTRUCTIONS,

Fixed deprecation warning:
    DeprecationWarning: invalid escape sequence '`'
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i think in JS was needed

@hwchase17 hwchase17 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 5, 2023
@hwchase17 hwchase17 merged commit 450eb91 into langchain-ai:master Jun 5, 2023
@spazm spazm deleted the cleanup/format_instructions_python_warning branch June 9, 2023 02:48
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
…hain-ai#5751)

Fixed python deprecation warning:
    DeprecationWarning: invalid escape sequence '`'
    
backticks (`) do not have special meaning in python strings and should
not be escaped.

-- @spazm on twitter

### Who can review:

@nfcampos ported this change from javascript, @hwchase17 wrote the
original STRUCTURED_FORMAT_INSTRUCTIONS,
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants