feat: Add support for the Solidity language #6054
Conversation
There was a problem hiding this comment.
Thanks for the contribution!
(1) Can you please add a short notebook with example usage in docs/modules/indexes/text_splitters/examples/.
(2) Also, run make format (if you are set up w/ Poetry here)*.
*I can do this for you if you are not set up for run formatting.
No problem sir, I'll do that rn |
|
Also, minor nit: do you mind rebasing on |
|
Also, please run LMK if you don't have poetry, etc set up and I can run for you. |
Yes sir, I'm doing the poetry etc setup |
|
@rlancemartin I have finished |
|
Thanks! |
<!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> ## Add Solidity programming language support for code splitter. Twitter: @0xjord4n_ <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> #### Who can review? Tag maintainers/contributors who might be interested: @hwchase17 <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @hwchase17 VectorStores / Retrievers / Memory - @dev2049 -->
Add Solidity programming language support for code splitter.
Twitter: @0xjord4n_
Who can review?
Tag maintainers/contributors who might be interested:
@hwchase17