-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update web_base.py to have verify option #6107
update web_base.py to have verify option #6107
Conversation
Chnage web base loader initialize method to have "verify" option. For example, before it gave SSL verification error in some webpages. This gives option to the users to set verify option to False if they want.
We propose an enhancement to the web-based loader initialize method by introducing a "verify" option. This enhancement addresses the issue of SSL verification errors encountered in certain web pages. By providing users with the option to set the verify parameter to False, we offer greater flexibility and control.
And by adding verify option: you can finally pass in headers such as
to bypass the SSL verification.
This solves a lot of issues that I faced in the recent past. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - seems great
@hwchase17 is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
Fix for bug in SitemapLoader `aiohttp` `get` does not accept `verify` argument, and currently throws error, so SitemapLoader is not working This PR fixes it by removing `verify` param for `get` function call Fixes #6107 #### Who can review? Tag maintainers/contributors who might be interested: @eyurtsev --------- Co-authored-by: techcenary <127699216+techcenary@users.noreply.github.com>
We propose an enhancement to the web-based loader initialize method by introducing a "verify" option. This enhancement addresses the issue of SSL verification errors encountered on certain web pages. By providing users with the option to set the verify parameter to False, we offer greater flexibility and control.
Fixes #6079
Who can review?
@eyurtsev @hwchase17