Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class promotion #6187

Merged
merged 24 commits into from
Jun 18, 2023
Merged

Fix class promotion #6187

merged 24 commits into from
Jun 18, 2023

Conversation

leo-gan
Copy link
Collaborator

@leo-gan leo-gan commented Jun 14, 2023

In LangChain, all module classes are enumerated in the __init__.py file of the correspondent module. But some classes were missed and were not included in the module __init__.py

This PR:

  • added the missed classes to the module __init__.py files
  • __init__.py:__all_ variable value (a list of the class names) was sorted
  • langchain.tools.sql_database.tool.QueryCheckerTool was renamed into the QuerySQLCheckerTool because it conflicted with langchain.tools.spark_sql.tool.QueryCheckerTool
  • changes to pyproject.toml:
    • added pgvector to pyproject.toml:extended_testing
    • added pandas to pyproject.toml:[tool.poetry.group.test.dependencies]
    • commented out the streamlit from collbacks/__init__.py, It is because now the streamlit requires Python >=3.7, !=3.9.7
  • fixed duplicate names in tools
  • fixed correspondent ut-s

Who can review?

@hwchase17
@dev2049

@leo-gan leo-gan marked this pull request as ready for review June 15, 2023 06:04
@leo-gan leo-gan changed the title fixed class promotion Fix class promotion Jun 16, 2023
@vercel
Copy link

vercel bot commented Jun 16, 2023

@leo-gan is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 merged commit c7ca350 into langchain-ai:master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants