-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dev container #6189
Update dev container #6189
Conversation
|
||
# Use the Python base image | ||
ARG VARIANT="3.11-bullseye" | ||
FROM mcr.microsoft.com/vscode/devcontainers/python:0-${VARIANT} AS langchain-dev-base | ||
FROM mcr.microsoft.com/devcontainers/python:0-${VARIANT} AS langchain-dev-base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, we will soon release a new major version of python in order to support debian:bookworm
devcontainers/images#622
I'd recommend switching once it's live to continue receiving security patches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for letting us know, @samruddhikhandale !
cc @eyurtsev FYI |
Are there any logs you would be able to share on this one? It's surprising that it would take 30 minutes unless we're installing ALL the optional dependencies. The list of actual requirements isn't that large |
What's the fastest way to build the dev container and codespace on your branch? I can look into it tomorrow morning if I get to it before you see this. |
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
Thanks so much for the review @samruddhikhandale! @vowelparrot you should be able to use the Code dropdown at the top of this PR: Or from my fork: https://github.com/bamurtaugh/langchain/tree/bamurtaugh/dev-container. It'd be awesome to have you try it out and see if there's something apparent from your perspective that'd be causing it to hang. |
We probably don't need to install all of "--with dev,test,docs" on container creation (unless it's really terrible to add additional dependencies). I'd remove the "docs" group and see how long it takes then |
Thanks for the recommendation @vowelparrot! I'm trying that now. Still going and it's been about 8 minutes, so still feels longer than expected? Edit: Have to step away for a bit, but it's still building at the 20-minute mark. 🤔 Does it take this long for other folks to generally run a poetry install? |
Fixes #6172
As described in #6172, I'd love to help update the dev container in this project.
Summary of changes:
mcr.microsoft.com/devcontainers/python
) rather than the deprecated image from vscode-dev-containersCOPY
to work properly, it needs the files (in this case,pyproject.toml
andpoetry.toml
) in the same directorycustomizations
andremoteUser
since they should be covered by the updated image in the DockerfileOutstanding questions:
poetry install
to take some time? It takes about 30 minutes for this dev container to finish building in a Codespace, but a user should only have to experience this once. Through some online investigation, this doesn't seem unusualWho can review?
Tag maintainers/contributors who might be interested: @vowelparrot
I was able to run through the various
make
commands mentioned in contributing.md successfully with this updated setup, and please let me know if there are questions or other tests I can help with to ensure everything is running well. Thanks so much!