Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAI functions dont work with async streaming... #6225 #6226

Merged

Conversation

ju-bezdek
Copy link
Contributor

Related to this #6225

Just copied the implementation from generate function to agenerate and tested it.

Didn't run any official tests thought

Fixes #6225

Before submitting

Who can review?

Tag maintainers/contributors who might be interested:
@hwchase17, @agola11

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gbrlmtrz
Copy link

gbrlmtrz commented Jun 15, 2023

I just came to open this same issue. I am to see someone already came with a solution. Do we have an ETA for release?

@vercel
Copy link

vercel bot commented Jun 17, 2023

@ju-bezdek is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

@ju-bezdek
Copy link
Contributor Author

Couldnt get peotry working on my machine to run the formatting ... finally got it working... not sure whether I followed the right workflow right now, but the formatting is fixed (literally just different spacing) and the tests passed

@vesper8
Copy link

vesper8 commented Jun 18, 2023

Also waiting for this to be merged.. hopefully soon!

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 merged commit e2f36ee into langchain-ai:master Jun 19, 2023
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAI functions dont work with async streaming...
4 participants