Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Entity Memory code documentation #6318

Merged

Conversation

lukestanley
Copy link
Contributor

Just adds some comments and docstring improvements.

There was some behaviour that was quite unclear to me at first like:

  • "when do things get updated?"
  • "why are there only entity names and no summaries?"
  • "why do the entity names disappear?"

Now it can be much more obvious to many.
@dev2049

I am lukestanley on Twitter.

@vercel
Copy link

vercel bot commented Jun 16, 2023

@lukestanley is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

@dev2049
Copy link
Contributor

dev2049 commented Jun 16, 2023

huge, thank you @lukestanley!

@lukestanley lukestanley force-pushed the entity_memory_documentation branch from 0568cbf to 7d0caf4 Compare June 16, 2023 23:48
@lukestanley
Copy link
Contributor Author

Black is now happy again with the latest force push to keep history tidy.

@dev2049 dev2049 merged commit 364f8e7 into langchain-ai:master Jun 17, 2023
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants