Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docstrings: top-level 1 #6626

Merged
merged 3 commits into from
Jun 23, 2023
Merged

docstrings: top-level 1 #6626

merged 3 commits into from
Jun 23, 2023

Conversation

leo-gan
Copy link
Collaborator

@leo-gan leo-gan commented Jun 23, 2023 •
edited
Loading

This PR targets the API Reference documentation.

  • Several classes and functions missed docstrings. These docstrings were created.
  • In several places this
except ImportError:
        raise ValueError(

    was replaced to 

except ImportError:
        raise ImportError(

@hwchase17 @dev2049 - please review :)

@vercel
Copy link

vercel bot commented Jun 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jun 23, 2023 3:55am

@leo-gan leo-gan marked this pull request as ready for review June 23, 2023 04:07
@dev2049
Copy link
Contributor

dev2049 commented Jun 23, 2023

amazing, thank you @leo-gan 🙏 🙏

@dev2049 dev2049 merged commit 1c81883 into langchain-ai:master Jun 23, 2023
@leo-gan leo-gan deleted the docs_api_ref_update branch June 24, 2023 06:58
This was referenced Jun 25, 2023
Closed
Merged
@leo-gan leo-gan changed the title added docstrings where they missed docstrings: top-level 1 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leo-gan @dev2049